Re: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged; ?

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged; ?
Date: 2014-07-03 13:03:10
Message-ID: CAHGQGwGSwUKWT0Hg0kQJsiQ_LJY4hrB-SC8onrLG-P+EwmhehQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> Hi,
>
> Fujii noticed that I'd used
> \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit
> in an extension upgrade script. That's obviously wrong, because it
> should say ALTER EXTENSION. The reason it's that way is that I copied
> the line from the unpackaged--1.0.sql file.
> I noticed all unpackaged--$version transition files miss the "FROM
> unpackaged" in that echo.
> I guess that's just a oversight which we should correct?

Maybe for user-friendness. But I think that's not so important fix enough
to backpatch.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-07-03 13:14:06 Re: docs: additional subsection for page-level locks in explicit-locking section
Previous Message Andres Freund 2014-07-03 12:32:17 Re: gaussian distribution pgbench