From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged; ? |
Date: | 2014-07-06 20:58:33 |
Message-ID: | CA+TgmoYjAEE+NtBQobrW3aruTxB7ONmdM+HSEdYKmO69iTJksw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 3, 2014 at 9:03 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> Hi,
>> Fujii noticed that I'd used
>> \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit
>> in an extension upgrade script. That's obviously wrong, because it
>> should say ALTER EXTENSION. The reason it's that way is that I copied
>> the line from the unpackaged--1.0.sql file.
>> I noticed all unpackaged--$version transition files miss the "FROM
>> unpackaged" in that echo.
>> I guess that's just a oversight which we should correct?
>
> Maybe for user-friendness. But I think that's not so important fix enough
> to backpatch.
Seems like a clear mistake to me. +1 for fixing it and back-patching.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2014-07-06 23:12:42 | Re: wrapping in extended mode doesn't work well with default pager |
Previous Message | Andrew Gierth | 2014-07-06 19:56:00 | Re: Performance regression: 9.2+ vs. ScalarArrayOpExpr vs. ORDER BY |