Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?
Date: 2014-07-02 19:26:41
Message-ID: 20140702192641.GD22738@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Fujii noticed that I'd used
\echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit
in an extension upgrade script. That's obviously wrong, because it
should say ALTER EXTENSION. The reason it's that way is that I copied
the line from the unpackaged--1.0.sql file.
I noticed all unpackaged--$version transition files miss the "FROM
unpackaged" in that echo.
I guess that's just a oversight which we should correct? Or is there
some rationale behind it?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2014-07-02 19:26:49 Re: log_error_verbosity and unexpected errors
Previous Message Fujii Masao 2014-07-02 19:18:25 Re: alter user set local_preload_libraries.