Re: pgsql: Move "#define inline __inline" from port/win32.h to c.h because

Lists: pgsql-committerspgsql-hackers
From: momjian(at)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Move "#define inline __inline" from port/win32.h to c.h because
Date: 2006-08-10 01:35:21
Message-ID: 20060810013521.B1E0A9FB309@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Move "#define inline __inline" from port/win32.h to c.h because Win32
interface builds like libpq need it.

Backpatch addition to 8.1.X.

Modified Files:
--------------
pgsql/src/include:
c.h (r1.209 -> r1.210)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/c.h.diff?r1=1.209&r2=1.210)
pgsql/src/include/port:
win32.h (r1.56 -> r1.57)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/port/win32.h.diff?r1=1.56&r2=1.57)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Move "#define inline __inline" from port/win32.h to c.h because
Date: 2006-08-10 02:12:51
Message-ID: 9149.1155175971@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> Move "#define inline __inline" from port/win32.h to c.h because Win32
> interface builds like libpq need it.

Huh? port/win32.h is #included by c.h (as pg_config_os.h), no?
I don't see why it's necessary to clutter c.h with this
platform-specific hack, when we have a perfectly fine mechanism
for not doing that.

regards, tom lane

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: Move "#define inline __inline"
Date: 2006-08-10 02:39:49
Message-ID: 200608100239.k7A2dnM00230@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Move "#define inline __inline" from port/win32.h to c.h because Win32
> > interface builds like libpq need it.
>
> Huh? port/win32.h is #included by c.h (as pg_config_os.h), no?
> I don't see why it's necessary to clutter c.h with this
> platform-specific hack, when we have a perfectly fine mechanism
> for not doing that.

Right. I was wrong and the problem was that the inline define was
missing in the win32.h. That has been fixed in a later commit.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +