| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] pgsql: Move "#define inline __inline" |
| Date: | 2006-08-10 02:39:49 |
| Message-ID: | 200608100239.k7A2dnM00230@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Move "#define inline __inline" from port/win32.h to c.h because Win32
> > interface builds like libpq need it.
>
> Huh? port/win32.h is #included by c.h (as pg_config_os.h), no?
> I don't see why it's necessary to clutter c.h with this
> platform-specific hack, when we have a perfectly fine mechanism
> for not doing that.
Right. I was wrong and the problem was that the inline define was
missing in the win32.h. That has been fixed in a later commit.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Gsmet | 2006-08-10 21:34:14 | pgfouine - www: last fixes for 0.7 |
| Previous Message | Tom Lane | 2006-08-10 02:36:29 | pgsql: Fix UNION/INTERSECT/EXCEPT so that when two inputs being merged |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-10 02:49:43 | Re: [HACKERS] Maintaining cluster order on insert |
| Previous Message | Stephen Frost | 2006-08-10 02:22:15 | Re: [BUGS] numerics lose scale and precision in views of unions |