Re: pgsql: Move "#define inline __inline" from port/win32.h to c.h because

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Move "#define inline __inline" from port/win32.h to c.h because
Date: 2006-08-10 02:12:51
Message-ID: 9149.1155175971@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> Move "#define inline __inline" from port/win32.h to c.h because Win32
> interface builds like libpq need it.

Huh? port/win32.h is #included by c.h (as pg_config_os.h), no?
I don't see why it's necessary to clutter c.h with this
platform-specific hack, when we have a perfectly fine mechanism
for not doing that.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-08-10 02:36:29 pgsql: Fix UNION/INTERSECT/EXCEPT so that when two inputs being merged
Previous Message Tom Lane 2006-08-10 02:06:23 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

Browse pgsql-hackers by date

  From Date Subject
Next Message Satoshi Nagayasu 2006-08-10 02:14:18 Re: pgstattuple extension for indexes
Previous Message Tom Lane 2006-08-10 02:06:23 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update