Re: poor wording on SSPI error message

Lists: pgsql-hackers
From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: poor wording on SSPI error message
Date: 2009-03-06 20:16:07
Message-ID: 20090306201607.GA3162@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi,

This message

r = (_QuerySecurityContextToken) (sspictx, &token);
if (r != SEC_E_OK)
{
FreeLibrary(secur32);
pg_SSPI_error(ERROR,
gettext_noop("could not get security token from context"), r);
}

looks poorly worded. What "context" is it talking about? Can we be a
bit more explicit? Any other thoughts on how to improve it?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: poor wording on SSPI error message
Date: 2009-03-06 22:03:35
Message-ID: 49B19DB7.1020909@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera wrote:
> Hi,
>
> This message
>
> r = (_QuerySecurityContextToken) (sspictx, &token);
> if (r != SEC_E_OK)
> {
> FreeLibrary(secur32);
> pg_SSPI_error(ERROR,
> gettext_noop("could not get security token from context"), r);
> }
>
> looks poorly worded. What "context" is it talking about? Can we be a
> bit more explicit? Any other thoughts on how to improve it?

Hmm. that should probalby read "could not get token from security
context", because that's what it's trying to do. But maybe you meant
something different from that as well?

/Magnus

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: poor wording on SSPI error message
Date: 2009-03-22 18:09:17
Message-ID: 14944.1237745357@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Alvaro Herrera wrote:
>>> gettext_noop("could not get security token from context"), r);
>>
>> looks poorly worded. What "context" is it talking about? Can we be a
>> bit more explicit? Any other thoughts on how to improve it?

> Hmm. that should probalby read "could not get token from security
> context", because that's what it's trying to do. But maybe you meant
> something different from that as well?

I changed this to "could not get token from SSPI security context",
since that term was already in use in a nearby error message. I also
fixed a couple of other issues in the same area --- in particular,
the messages wouldn't have gotten translated ...

regards, tom lane