| Lists: | pgsql-hackers |
|---|
| From: | Pavel Raiskup <praiskup(at)redhat(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | hhorak(at)redhat(dot)com |
| Subject: | Public header files change |
| Date: | 2014-02-21 11:11:42 |
| Message-ID: | 6127979.mjyzd4gOKe@nb.usersys.redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
It seems to be unlikely to me, but are the changed symbols mentioned in
git-log commit message 5f173040e324 supposed to be used other than
internally? Snip:
Avoid repeated name lookups during table and index DDL.
...
to the Constraint node (FkConstraint in 8.4). Third-party code
calling these functions or using the Constraint node will require
updating.
....
These seem to be pretty internal symbols to me, but I rather asking here.
Is there some project we know off that is using this functions (or is
there some obvious usecase for third-parties)?
Pavel
| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavel Raiskup <praiskup(at)redhat(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, hhorak(at)redhat(dot)com |
| Subject: | Re: Public header files change |
| Date: | 2014-02-21 11:19:02 |
| Message-ID: | 20140221111902.GY28858@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 2014-02-21 12:11:42 +0100, Pavel Raiskup wrote:
> It seems to be unlikely to me, but are the changed symbols mentioned in
> git-log commit message 5f173040e324 supposed to be used other than
> internally? Snip:
> ....
> These seem to be pretty internal symbols to me, but I rather asking here.
> Is there some project we know off that is using this functions (or is
> there some obvious usecase for third-parties)?
I don't know of any public/open code, but I have seen DefineIndex()
being used directly in some company's private code. And it's probably
not a good idea to do so.
Since such code should also adapt to be safe, it's probably a good idea
if it breaks. If such code is used without recompiling against an
updated PG, it's likely that it will error out with a somewhat strange
message (Cache lookup failure for Oid <ptr as uint32>), but it shouldn't
crash.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services