From: | Ronan Dunklau <rdunklau(at)gmail(dot)com> |
---|---|
To: | PgHacker <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Extensions makefiles - coverage |
Date: | 2013-07-25 15:07:31 |
Message-ID: | CAJWq4=Z+1P8ZWPK72j5FOOuCH7kOZnUmsY3u7aOFHFeTS-YQ5Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello.
I was having trouble figuring how to use the coverage targets when
using an extension.
I am using approximatively the layout that was proposed here:
http://www.postgresql.org/message-id/51BB1B6E.2070705@dunslane.net
It looks like everything is hard-coded to take the source and the
gcda, gcno files in the base directory, but these files lay in a src
directory with the proposed layout.
It may be better to base the .gcda file discovery on the OBJS
variables when using PGXS.
Please find attached a small patch that implements this. There is
probably a better way than the redundant rm $(gcda_files) / rm *.gcda
to cleanup the generated files.
With the attached patch, the following targets seem to have the same
behaviour as on the current HEAD, both on the whole tree and on
individual contrib modules:
- coverage-html
- clean
- coverage-clean
- clean-coverage
I noticed that make clean leaves gcda and gcov files on the current
HEAD, and this is no different with the given patch.
I also tested it against several pgxn extensions, and it seems to work fine.
Attachment | Content-Type | Size |
---|---|---|
coverage_pgxs.patch | application/octet-stream | 948 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Ronan Dunklau | 2013-07-25 15:08:55 | Re: Extensions makefiles - coverage |
Previous Message | Bruce Momjian | 2013-07-25 14:57:28 | pg_upgrade -j broken on Windows |