Re: Support for REINDEX CONCURRENTLY

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: Support for REINDEX CONCURRENTLY
Date: 2013-07-03 17:41:45
Message-ID: CAHGQGwHL=Ngqtvot22h8B6eun_q9tWMWWMqc3yCHS4qp9T1p7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 4, 2013 at 2:36 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2013-07-04 02:32:32 +0900, Michael Paquier wrote:
>> > Wouldn't it make more sense to fetch the toast index oid in the query
>> > ontop instead of making a query for every relation?

+1
I changed the query that way. Updated version of the patch attached.

Also I updated the rules.out because Michael changed the system_views.sql.
Otherwise, the regression test would fail.

Will commit this patch.

Regards,

--
Fujii Masao

Attachment Content-Type Size
20130704_1_remove_reltoastidxid_v18.patch application/octet-stream 45.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-07-03 18:09:29 Re: proposal: simple date constructor from numeric values
Previous Message Tom Lane 2013-07-03 17:38:13 Re: Add regression tests for COLLATE