| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add regression tests for COLLATE |
| Date: | 2013-07-03 17:38:13 |
| Message-ID: | 20683.1372873093@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-07-03 13:29:18 -0400, Robert Haas wrote:
>> I think that's a killer blow for this particular patch. I'm going to
>> set this to rejected in the CF app.
> Can't we use a alternative expected file for those?
Alternative expected files are a PITA to maintain, at least for
committers who don't have a platform that can reproduce the alternative
behavior. If this test were of somewhat higher value I'd be in favor of
fixing it that way, but given that it's been seriously constrained by
the portability issues that were already considered, I'm not sure it's
worth our trouble. (There's also no very strong reason to believe that
we found out all the remaining portability issues. Maybe we should have
left it in there for a day, just to see if the buildfarm would show any
other symptoms besides this one.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2013-07-03 17:41:45 | Re: Support for REINDEX CONCURRENTLY |
| Previous Message | Andres Freund | 2013-07-03 17:36:20 | Re: Support for REINDEX CONCURRENTLY |