From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Set new system identifier using pg_resetxlog |
Date: | 2014-06-30 10:57:58 |
Message-ID: | CAHGQGwG-J0AtE=x+bOnV7LFSOOWxt9x3x9sp3hcqTo=25fqzjg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jun 29, 2014 at 11:18 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2014-06-29 19:44:21 +0530, Abhijit Menon-Sen wrote:
>> At 2014-06-27 00:51:02 +0200, petr(at)2ndquadrant(dot)com wrote:
>> >
>> > Also based on Alvaro's comment, I replaced the scanf parsing code with
>> > strtoul(l) function.
>>
>> As far as I can tell (from the thread and a quick look at the patch),
>> your latest version of the patch addresses all the review comments.
>>
>> Should I mark this ready for committer now?
>
> Well, we haven't really agreed on a way forward yet. Robert disagrees
> that the feature is independently useful and thinks it might be
> dangerous for some users. I don't agree with either of those points, but
> that doesn't absolve the patch from the objection. I think tentatively
> have been more people in favor, but it's not clear cut imo.
So what's the usecase of this feature? If it's for "normal operation",
using pg_resetxlog for that is a bit dangerous because it can corrupt
the database easily.
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Abhijit Menon-Sen | 2014-06-30 11:01:08 | Re: psql: show only failed queries |
Previous Message | Pavel Stehule | 2014-06-30 10:48:30 | Re: psql: show only failed queries |