From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com>, Samrat Revagade <revagade(dot)samrat(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: psql: show only failed queries |
Date: | 2014-06-30 11:01:08 |
Message-ID: | 20140630110108.GZ31357@toroid.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 2014-06-30 12:48:30 +0200, pavel(dot)stehule(at)gmail(dot)com wrote:
>
> + <para>
> + Print a failed SQL commands to standard error output. This is
> + equivalent to setting the variable <varname>ECHO</varname> to
> + <literal>errors</literal>.
No "a", just "Print failed SQL commands …".
> - <option>-e</option>.
> + <option>-e</option>. If set to <literal>error</literal> then only
> + failed queries are displayed.
Should be "errors" here, not "error".
> printf(_(" -a, --echo-all echo all input from script\n"));
> + printf(_(" -b --echo-errors echo failed commands sent to server\n"));
> printf(_(" -e, --echo-queries echo commands sent to server\n"));
Should have a comma after -b to match other options. Also I would remove
"sent to server" from the description: "echo failed commands" is fine.
Otherwise looks fine. I see no reason to wait for further feedback, so
I'll mark this ready for committer if you make the above corrections.
At some point, you should probably also update your --help-variables
patch to add this new value to the description of ECHO.
-- Abhijit
From | Date | Subject | |
---|---|---|---|
Next Message | Matheus de Oliveira | 2014-06-30 11:05:24 | Re: How about a proper TEMPORARY TABLESPACE? |
Previous Message | Fujii Masao | 2014-06-30 10:57:58 | Re: Set new system identifier using pg_resetxlog |