| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Set new system identifier using pg_resetxlog |
| Date: | 2014-06-29 14:18:34 |
| Message-ID: | 20140629141834.GE21422@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-06-29 19:44:21 +0530, Abhijit Menon-Sen wrote:
> At 2014-06-27 00:51:02 +0200, petr(at)2ndquadrant(dot)com wrote:
> >
> > Also based on Alvaro's comment, I replaced the scanf parsing code with
> > strtoul(l) function.
>
> As far as I can tell (from the thread and a quick look at the patch),
> your latest version of the patch addresses all the review comments.
>
> Should I mark this ready for committer now?
Well, we haven't really agreed on a way forward yet. Robert disagrees
that the feature is independently useful and thinks it might be
dangerous for some users. I don't agree with either of those points, but
that doesn't absolve the patch from the objection. I think tentatively
have been more people in favor, but it's not clear cut imo.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2014-06-29 14:21:34 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Previous Message | Abhijit Menon-Sen | 2014-06-29 14:14:21 | Re: Set new system identifier using pg_resetxlog |