| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Thom Brown <thom(at)linux(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Yeb Havinga <yeb(dot)havinga(at)portavita(dot)nl> |
| Subject: | Re: WITH CHECK OPTION bug [was RLS Design] |
| Date: | 2014-09-21 09:20:31 |
| Message-ID: | CAEZATCVRMrJk85CPKQpqCzHyAGJSSi1OSqo=WtfMdrBod_ogKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20 September 2014 14:08, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Sat, Sep 20, 2014 at 7:03 AM, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>> Fortunately it looks pretty trivial though. The patch attached fixes
>> the above test cases.
>> Obviously this needs to be fixed in 9.4 and HEAD.
> Wouldn't it be better if bundled with some regression tests?
Yeah OK, fair point. Here are some tests that cover that code path.
I've also thrown in a test with prepared statements, although that
case was already working, it seemed worth checking.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| with-check-option.patch | text/x-diff | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2014-09-21 09:27:59 | proposal: window function - change_number |
| Previous Message | Craig Ringer | 2014-09-21 07:52:48 | Re: Help to startup |