Re: WITH CHECK OPTION bug [was RLS Design]

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Thom Brown <thom(at)linux(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Yeb Havinga <yeb(dot)havinga(at)portavita(dot)nl>
Subject: Re: WITH CHECK OPTION bug [was RLS Design]
Date: 2014-09-21 14:04:52
Message-ID: 20140921140452.GM16422@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dean,

* Dean Rasheed (dean(dot)a(dot)rasheed(at)gmail(dot)com) wrote:
> On 20 September 2014 14:08, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> > On Sat, Sep 20, 2014 at 7:03 AM, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> >> Fortunately it looks pretty trivial though. The patch attached fixes
> >> the above test cases.
> >> Obviously this needs to be fixed in 9.4 and HEAD.
> > Wouldn't it be better if bundled with some regression tests?

Agreed.

> Yeah OK, fair point. Here are some tests that cover that code path.
> I've also thrown in a test with prepared statements, although that
> case was already working, it seemed worth checking.

Thanks! Looks good, but will review in more depth, address the other
comments on this thread (typo, adding more documentation) and
investigate the results from the Coverity run this morning this evening
and should be able to get everything addressed in the next couple days.
Obviously, I'll be back-patching this fix to 9.4 too.

Thanks again!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-09-21 14:06:48 Re: pgsql: Row-Level Security Policies (RLS)
Previous Message Peter Eisentraut 2014-09-21 14:04:38 Re: pgsql: Row-Level Security Policies (RLS)