| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kevin Grittner <kgrittn(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add infrastructure to support EphemeralNamedRelation references. |
| Date: | 2017-04-01 05:21:29 |
| Message-ID: | CACjxUsMfb+fOO-0fYK=8mWTk+0iU0KLmqJEf8XhkiMH=U6xZ1Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sat, Apr 1, 2017 at 12:01 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> rhinoceros says you missed contrib/sepgsql.
Yeah, I saw that and have pushed an attempt to fix.
> More generally, if you hack the API of some globally-referenced function,
> you ought to grep for references to it rather than just assume your
> compiler will find them all for you. For one thing, that approach is a
> great way to fail to update relevant comments.
That's what I normally do, and thought that I had here, but clearly
I messed up. The log shows that even in 2014, when this was
written, those calls were there.
> (And while I'm bitching, you definitely failed to update ProcessUtility's
> header comment, which like most significant functions takes some pains
> to describe all the arguments.)
Will fix.
--
Kevin Grittner
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2017-04-01 06:01:46 | Re: pgsql: Add infrastructure to support EphemeralNamedRelation references. |
| Previous Message | Kevin Grittner | 2017-04-01 05:12:14 | pgsql: Try to fix breakage of sepgsql hooks by ENR patch. |