Re: pgsql: Add infrastructure to support EphemeralNamedRelation references.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kevin Grittner <kgrittn(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add infrastructure to support EphemeralNamedRelation references.
Date: 2017-04-01 05:01:29
Message-ID: 27842.1491022889@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

rhinoceros says you missed contrib/sepgsql.

More generally, if you hack the API of some globally-referenced function,
you ought to grep for references to it rather than just assume your
compiler will find them all for you. For one thing, that approach is a
great way to fail to update relevant comments.

(And while I'm bitching, you definitely failed to update ProcessUtility's
header comment, which like most significant functions takes some pains
to describe all the arguments.)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2017-04-01 05:12:14 pgsql: Try to fix breakage of sepgsql hooks by ENR patch.
Previous Message Kevin Grittner 2017-04-01 04:32:13 pgsql: Add transition table support to plpgsql.