| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: timeline signedness |
| Date: | 2013-08-14 12:40:26 |
| Message-ID: | CABUevEySdi3kdjV8t6N23mtd75MFg_fa-9cttOTiXDfJ5kg0pA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 13, 2013 at 1:31 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Wed, 2013-08-07 at 21:55 -0400, Peter Eisentraut wrote:
>> WAL timelines are unsigned 32-bit integers everywhere, except the
>> replication parser (replication/repl_gram.y and
>> replication/repl_scanner.l) treats them as signed 32-bit integers. It's
>> obviously a corner case, but it would be prudent to be correct about
>> this. It should be easy to fix in those grammar files.
>
> Here is a patch to fix this.
Looks fine to me, and looks like the correct thing to do.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-08-14 13:20:58 | Re: timeline signedness |
| Previous Message | Michael Paquier | 2013-08-14 12:04:06 | Re: Regarding BGworkers |