Re: timeline signedness

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: timeline signedness
Date: 2013-08-14 13:20:58
Message-ID: 520B843A.6090001@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.08.2013 14:31, Peter Eisentraut wrote:
> On Wed, 2013-08-07 at 21:55 -0400, Peter Eisentraut wrote:
>> WAL timelines are unsigned 32-bit integers everywhere, except the
>> replication parser (replication/repl_gram.y and
>> replication/repl_scanner.l) treats them as signed 32-bit integers. It's
>> obviously a corner case, but it would be prudent to be correct about
>> this. It should be easy to fix in those grammar files.

+1

> Here is a patch to fix this.

If I'm reading this correctly, timeline 0 no longer throws an error with
this patch.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2013-08-14 13:30:45 Re: StrategyGetBuffer optimization, take 2
Previous Message Magnus Hagander 2013-08-14 12:40:26 Re: timeline signedness