| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | furuyao(at)pm(dot)nttdata(dot)co(dot)jp |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog and replication slots |
| Date: | 2014-08-15 08:17:21 |
| Message-ID: | CAB7nPqQTezonK9c63JrBibDOt4RC8og=ZUni60OyM=H4NTXakA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for your review.
On Fri, Aug 15, 2014 at 12:56 AM, <furuyao(at)pm(dot)nttdata(dot)co(dot)jp> wrote:
> At consistency with pg_recvlogical, do you think about --start?
I did not add that for the sake of backward-compatibility as in
pg_recvlogical an action is mandatory. It is not the case now of
pg_receivexlog.
> [postgres postgresql-6aa6158]$ make > /dev/null
> streamutil.c: In function 'CreateReplicationSlot':
> streamutil.c:244: warning: suggest parentheses around '&&' within '||'
I see. Here is a rebased patch.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20140815_slot_creation_pg_receivexlog_v2.patch | text/x-patch | 11.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-08-15 08:20:35 | Re: pg_shmem_allocations view |
| Previous Message | Marti Raudsepp | 2014-08-15 08:12:11 | Re: pg_shmem_allocations view |