Re: jsonb and nested hstore

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Christophe Pettus <xof(at)thebuild(dot)com>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: jsonb and nested hstore
Date: 2014-03-05 17:26:13
Message-ID: CA+Tgmoae_j0=EKHjTZ=8B=zrW2uuacRy_jyDe-7mw7TqwvXeqg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 5, 2014 at 11:50 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Wed, Mar 5, 2014 at 11:34:10AM -0500, Stephen Frost wrote:
>> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> > Just out of curiosity, exactly what features are missing from jsonb
>> > today that are available with hstore? How long would it take to
>> > copy-and-paste all that code, if someone were to decide to do the
>> > work instead of argue about it?
>>
>> Somewhere upthread, Peter seemed to estimate it at a day, if I
>> understood correctly. If that's accurate, I'm certainly behind getting
>> it done and in and moving on. I'm sure no one particularly likes a
>> bunch of copy/pasteing of code, but if it would get us to the point of
>> having a really working jsonb that everyone is happy with, I'm all for
>> it.
>>
>> It's not clear how much different it would be if we waited til 9.5
>> either- do we anticipate a lot of code changes beyond the copy/paste for
>> these?
>
> What _would_ be interesting is to move all the hstore code into core,
> and have hstore contrib just call the hstore core parts. That way, you
> have one copy of the code, it is shared with JSONB, but hstore remains
> as an extension that you can change or remove later.

That seems like an approach possibly worth investigating. It's not
too different from what we did when we moved text search into core.
The basic idea seems to be that we want jsonb in core, and we expect
it to replace hstore, but we can't get just get rid of hstore because
it has too many users.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2014-03-05 17:27:51 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message Tom Lane 2014-03-05 17:19:16 Re: jsonb and nested hstore