Re: [HACKERS] Issues with generate_series using integer boundaries

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: Thom Brown <thom(at)linux(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PGSQL Mailing List <pgsql-general(at)postgresql(dot)org>
Subject: Re: [HACKERS] Issues with generate_series using integer boundaries
Date: 2011-02-08 09:22:18
Message-ID: AANLkTikxsR5ugwxsj4yFMYrn0wOArWmKkJZShvAYvcxP@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Mon, Feb 7, 2011 at 20:38, Thom Brown <thom(at)linux(dot)com> wrote:
> Yes, of course, int8 functions are separate.  I attach an updated
> patch, although I still think there's a better way of doing this.

Thanks. Please add the patch to the *current* commitfest
because it's a bugfix.
https://commitfest.postgresql.org/action/commitfest_view?id=9

I've not tested the patch yet, but if we could drop the following
line in the patch, the code could be much cleaner.
/* ensure first value in series should exist */

> I'm not sure how this should be handled.  Should there just be a check
> for either kind of infinity and return an error if that's the case?  I

Maybe so. It also works if we had infinity on timestamp overflow, but
I've not tested yet. Anyway, we need similar fix for timestamp versions.

--
Itagaki Takahiro

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Pavel Stehule 2011-02-08 09:42:46 Re: many schemas or many databases
Previous Message Thomas Markus 2011-02-08 09:16:34 Re: many schemas or many databases

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2011-02-08 09:25:34 Re: SSI patch version 14
Previous Message Heikki Linnakangas 2011-02-08 08:52:16 PostgreSQL FDW update