From: | Thom Brown <thom(at)linux(dot)com> |
---|---|
To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PGSQL Mailing List <pgsql-general(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Issues with generate_series using integer boundaries |
Date: | 2011-02-08 10:12:47 |
Message-ID: | AANLkTikSRudj6B6yeJ0L+ft+mVGbomkbR-rVzf0RNaVX@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
On 8 February 2011 09:22, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> On Mon, Feb 7, 2011 at 20:38, Thom Brown <thom(at)linux(dot)com> wrote:
>> Yes, of course, int8 functions are separate. I attach an updated
>> patch, although I still think there's a better way of doing this.
>
> Thanks. Please add the patch to the *current* commitfest
> because it's a bugfix.
> https://commitfest.postgresql.org/action/commitfest_view?id=9
>
> I've not tested the patch yet, but if we could drop the following
> line in the patch, the code could be much cleaner.
> /* ensure first value in series should exist */
>
>> I'm not sure how this should be handled. Should there just be a check
>> for either kind of infinity and return an error if that's the case? I
>
> Maybe so. It also works if we had infinity on timestamp overflow, but
> I've not tested yet. Anyway, we need similar fix for timestamp versions.
Well, in its current state, I expect it to get rejected, but I guess
at least it gets a better chance of being looked at. I've added it to
the commitfest now.
--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935
From | Date | Subject | |
---|---|---|---|
Next Message | Oleg Bartunov | 2011-02-08 10:34:32 | Re: fulltext search and hunspell |
Previous Message | OTSUKA Kenji | 2011-02-08 10:09:46 | about PostgreSQL 9.0.3 RPMs |
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2011-02-08 10:51:11 | Re: Extensions support for pg_dump, patch v27 |
Previous Message | Ibrar Ahmed | 2011-02-08 10:05:40 | Re: REVIEW: Determining client_encoding from client locale |