Re: Add more regression tests for CREATE OPERATOR

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: pgsql-hackers(at)postgresql(dot)org, Szymon Guz <mabewlun(at)gmail(dot)com>
Subject: Re: Add more regression tests for CREATE OPERATOR
Date: 2013-06-26 19:10:36
Message-ID: 51CB3CAC.1050003@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> Is it enough to provide the description in the commitfest app, or is that
> better to send an email and provide link in commitfest?

Better to do it here, on the list.

> This is a patch only with regression tests, is that enough to write
> something like: "This patch applies cleanly on trunk code. All tests pass,
> the test coverage increses as provided."? Or do you expect some more info?

Yes, mainly:

a) does it test what it purports to test?

b) do the tests pass on your machine?

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-06-26 19:12:44 Re: Kudos for Reviewers -- straw poll
Previous Message Fabien COELHO 2013-06-26 19:08:50 Re: Add more regression tests for dbcommands