Re: Add more regression tests for CREATE OPERATOR

From: Szymon Guz <mabewlun(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add more regression tests for CREATE OPERATOR
Date: 2013-06-26 19:52:15
Message-ID: CAFjNrYuj5T5KUJ_cTdSsb9241gc7MeKXbRKBSVrSR8f3aKkidQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 26 June 2013 21:10, Josh Berkus <josh(at)agliodbs(dot)com> wrote:

>
> > Is it enough to provide the description in the commitfest app, or is that
> > better to send an email and provide link in commitfest?
>
> Better to do it here, on the list.
>
> > This is a patch only with regression tests, is that enough to write
> > something like: "This patch applies cleanly on trunk code. All tests
> pass,
> > the test coverage increses as provided."? Or do you expect some more
> info?
>
> Yes, mainly:
>
> a) does it test what it purports to test?
>
> b) do the tests pass on your machine?
>
>
Done, could you confirm that it is OK now?
I've also checked all the patches on the newest trunk.

thanks,
Szymon

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-06-26 19:59:36 Re: [PATCH] Fix conversion for Decimal arguments in plpython functions
Previous Message Jeff Janes 2013-06-26 19:32:24 Re: Hash partitioning.