| From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
|---|---|
| To: | Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: patch review : Add ability to constrain backend temporary file space |
| Date: | 2011-06-17 01:51:37 |
| Message-ID: | 4DFAB329.7050806@catalyst.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17/06/11 13:08, Mark Kirkwood wrote:
> On 17/06/11 09:49, Cédric Villemain wrote:
>>
>> I have issues applying it.
>> Please can you remove trailing space?
>> Also, you can generate a cool patch like this :
>>
>> get git-external-diff from postgres/src/tools to /usr/lib/git-core/
>> chmod +x it
>> export GIT_EXTERNAL_DIFF=git-external-diff
>> git format-patch --ext-diff origin
I think I have the trailing spaces removed, and patch is updated for the
variable renaming recently done in fd.c
I have no idea why I can't get the git apply to work (obviously I have
exceeded by git foo by quite a ways), but it should apply for you I hope
(as it patches fine).
regards
Mark
| Attachment | Content-Type | Size |
|---|---|---|
| temp-files-v5.1.patch.gz | application/x-gzip | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-06-17 01:59:09 | Re: planinstr, showing planner time on EXPLAIN |
| Previous Message | Alvaro Herrera | 2011-06-17 01:42:43 | Re: Boolean operators without commutators vs. ALL/ANY |