Re: sepgsql contrib module

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Kohei Kaigai <Kohei(dot)Kaigai(at)EU(dot)NEC(dot)COM>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: sepgsql contrib module
Date: 2011-02-14 21:21:39
Message-ID: 21421.1297718499@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Thew makefile still has this bogosity:

> sepgsql-regtest.pp: sepgsql-regtest.te
> $(MAKE) -f $(DESTDIR)/usr/share/selinux/devel/Makefile $@

> We need to fix that up before we even think of trying to get buildfarm
> coverage. The presence and location of this makefile should be
> determined at configure time, ISTM.

I'd suggest just getting rid of the $(DESTDIR), which is flat out wrong,
and leaving it as-is otherwise. The portability level of this code is
somewhere at the bad-joke level anyway; if you're trying to get it to
run anywhere but a recent Fedora/RHEL system, I really doubt that path
is the first or biggest problem you'll hit.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Urbański 2011-02-14 21:22:49 Re: pl/python do not delete function arguments
Previous Message Jan Urbański 2011-02-14 21:13:18 Re: pl/python do not delete function arguments