Re: sepgsql contrib module

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kohei Kaigai <Kohei(dot)Kaigai(at)EU(dot)NEC(dot)COM>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: sepgsql contrib module
Date: 2011-02-14 22:29:09
Message-ID: 4D59ACB5.2010101@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/14/2011 04:21 PM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> Thew makefile still has this bogosity:
>> sepgsql-regtest.pp: sepgsql-regtest.te
>> $(MAKE) -f $(DESTDIR)/usr/share/selinux/devel/Makefile $@
>> We need to fix that up before we even think of trying to get buildfarm
>> coverage. The presence and location of this makefile should be
>> determined at configure time, ISTM.
> I'd suggest just getting rid of the $(DESTDIR), which is flat out wrong,
> and leaving it as-is otherwise. The portability level of this code is
> somewhere at the bad-joke level anyway; if you're trying to get it to
> run anywhere but a recent Fedora/RHEL system, I really doubt that path
> is the first or biggest problem you'll hit.

Yeah. The next thing I hit was this:

[andrew(at)aurelia sepgsql]$ make -f /usr/share/selinux/devel/Makefile
sepgsql-regtest.pp
cat: /selinux/mls: No such file or directory
make: *** No rule to make target `sepgsql-regtest.pp'. Stop.
[andrew(at)aurelia sepgsql]$

That's not very nice.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marti Raudsepp 2011-02-14 22:39:25 Re: FOR KEY LOCK foreign keys
Previous Message Daniel Farina 2011-02-14 22:13:31 Re: Replication server timeout patch