Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Neil Conway <neilc(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE
Date: 2006-07-02 16:24:57
Message-ID: 200607021624.k62GOvh08577@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Neil Conway wrote:
> Log Message:
> -----------
> Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep
> the read lock we hold on the table's parent relation until commit.
> Update equalfuncs.c for the new field in AlterTableCmd. Various
> improvements to comments, variable names, and error reporting.
>
> There is room for further improvement here, but this is at least
> a step in the right direction.

Thanks, that is what was needed. The author obviously took the patch as
far as he could, and we needed to adjust his XXX areas, rather than not
apply the patch and have the code drifting.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2006-07-02 17:18:33 Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE
Previous Message User Pgstudy 2006-07-02 14:44:51 fulldisjunction - fd: Moved the index queries to work with paramters and

Browse pgsql-hackers by date

  From Date Subject
Next Message Agent M 2006-07-02 16:25:43 Re: different sort order in windows and linux version
Previous Message Bruce Momjian 2006-07-02 16:23:39 Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)