From: | neilc(at)postgresql(dot)org (Neil Conway) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Do a pass of code review for the ALTER TABLE ADD INHERITS patch. |
Date: | 2006-07-02 05:17:26 |
Message-ID: | 20060702051726.5BD179FA4E4@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Log Message:
-----------
Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep
the read lock we hold on the table's parent relation until commit.
Update equalfuncs.c for the new field in AlterTableCmd. Various
improvements to comments, variable names, and error reporting.
There is room for further improvement here, but this is at least
a step in the right direction.
Modified Files:
--------------
pgsql/src/backend/commands:
tablecmds.c (r1.190 -> r1.191)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c.diff?r1=1.190&r2=1.191)
pgsql/src/backend/nodes:
copyfuncs.c (r1.340 -> r1.341)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c.diff?r1=1.340&r2=1.341)
equalfuncs.c (r1.274 -> r1.275)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c.diff?r1=1.274&r2=1.275)
pgsql/src/test/regress/expected:
alter_table.out (r1.95 -> r1.96)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out.diff?r1=1.95&r2=1.96)
From | Date | Subject | |
---|---|---|---|
Next Message | User Pgstudy | 2006-07-02 14:44:51 | fulldisjunction - fd: Moved the index queries to work with paramters and |
Previous Message | Bruce Momjian | 2006-07-02 02:23:23 | pgsql: Add FILLFACTOR to CREATE INDEX. |
From | Date | Subject | |
---|---|---|---|
Next Message | Martijn van Oosterhout | 2006-07-02 10:13:02 | Re: different sort order in windows and linux version |
Previous Message | Tom Lane | 2006-07-02 04:06:40 | Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) |