From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Fwd: Discussion - Search Objects |
Date: | 2011-07-05 19:28:57 |
Message-ID: | 1309894137.2762.2.camel@laptop |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Mon, 2011-07-04 at 23:42 +0200, Jasmin Dizdarevic wrote:
>
>
> 2011/7/4 Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote:
> > On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote:
> > > Could somebody review the patch and maybe commit it?
> > >
> >
> > I'll look into it tonight, unless someone beats me to it.
> >
>
>
> Thank's for checking.
>
>
> Seems mostly good to me, but I have too questions:
>
> * why do you use twice the Trim command in
>
> "browser->GetItemText(parent).BeforeFirst('(').Trim().Trim(false)"?
>
>
> I've misunderstood the wx-docs.
>
> * why is the search object menu only available to non
> maintenance DB?
> (((pgDatabase *)obj)->GetName() != ((pgDatabase
> *)obj)->GetServer()->GetDatabaseName())
>
>
>
> copy-paste mistake
>
>
> patch attached.
>
OK, I'm still working on it. I need the search.png image, can you send
it to me? as I can't apply the patch, I can't extract the image. Thanks.
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Jasmin Dizdarevic | 2011-07-05 19:33:25 | Re: Fwd: Discussion - Search Objects |
Previous Message | Thom Brown | 2011-07-05 19:23:16 | [FEATURE] Add schema option to all relevant objects |