From: | Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Fwd: Discussion - Search Objects |
Date: | 2011-07-05 19:33:25 |
Message-ID: | CAOveQuP9rPF-gV9bTsBT0CboMYyTA=0g=aQcYsZVQx+1x==ZaQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Sure.
2011/7/5 Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> On Mon, 2011-07-04 at 23:42 +0200, Jasmin Dizdarevic wrote:
> >
> >
> > 2011/7/4 Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> > On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote:
> > > On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote:
> > > > Could somebody review the patch and maybe commit it?
> > > >
> > >
> > > I'll look into it tonight, unless someone beats me to it.
> > >
> >
> >
> > Thank's for checking.
> >
> >
> > Seems mostly good to me, but I have too questions:
> >
> > * why do you use twice the Trim command in
> >
> >
> "browser->GetItemText(parent).BeforeFirst('(').Trim().Trim(false)"?
> >
> >
> > I've misunderstood the wx-docs.
> >
> > * why is the search object menu only available to non
> > maintenance DB?
> > (((pgDatabase *)obj)->GetName() != ((pgDatabase
> > *)obj)->GetServer()->GetDatabaseName())
> >
> >
> >
> > copy-paste mistake
> >
> >
> > patch attached.
> >
>
> OK, I'm still working on it. I need the search.png image, can you send
> it to me? as I can't apply the patch, I can't extract the image. Thanks.
>
>
> --
> Guillaume
> http://blog.guillaume.lelarge.info
> http://www.dalibo.com
>
>
Attachment | Content-Type | Size |
---|---|---|
image/png | 41.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2011-07-05 19:35:02 | Re: Fwd: Discussion - Search Objects |
Previous Message | Guillaume Lelarge | 2011-07-05 19:28:57 | Re: Fwd: Discussion - Search Objects |