| From: | Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: Fwd: Discussion - Search Objects |
| Date: | 2011-07-04 21:42:12 |
| Message-ID: | CAOveQuNsoAZLBau4XWex-6MeYE-+fR25xqqY+u5GyadP8NC0rA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
2011/7/4 Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote:
> > On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote:
> > > Could somebody review the patch and maybe commit it?
> > >
> >
> > I'll look into it tonight, unless someone beats me to it.
> >
>
> Thank's for checking.
> Seems mostly good to me, but I have too questions:
>
> * why do you use twice the Trim command in
> "browser->GetItemText(parent).BeforeFirst('(').Trim().Trim(false)"?
>
I've misunderstood the wx-docs.
> * why is the search object menu only available to non maintenance DB?
> (((pgDatabase *)obj)->GetName() != ((pgDatabase
> *)obj)->GetServer()->GetDatabaseName())
>
> copy-paste mistake
patch attached.
>
> --
> Guillaume
> http://blog.guillaume.lelarge.info
> http://www.dalibo.com
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Doubletrimmed-string-in-frmMain-GetNodePath-and-wron.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2011-07-05 19:23:16 | [FEATURE] Add schema option to all relevant objects |
| Previous Message | Guillaume Lelarge | 2011-07-04 21:23:47 | Re: Fwd: Discussion - Search Objects |