Re: Review: Patch to compute Max LSN of Data Pages

From: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
To: "'Andres Freund'" <andres(at)2ndquadrant(dot)com>, "'Hari Babu'" <haribabu(dot)kommi(at)huawei(dot)com>
Cc: "'Robert Haas'" <robertmhaas(at)gmail(dot)com>, "'Josh Berkus'" <josh(at)agliodbs(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: Patch to compute Max LSN of Data Pages
Date: 2013-07-08 11:40:43
Message-ID: 015101ce7bcf$fb8d47f0$f2a7d7d0$@kapila@huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Monday, July 08, 2013 4:26 PM Andres Freund wrote:
> On 2013-07-08 16:17:54 +0530, Hari Babu wrote:
> > + This utility can also be used to decide whether backup is
> required or not when the data page
> > + in old-master precedes the last applied LSN in old-standby
> (i.e., new-master) at the
> > + moment of the failover.
> > + </para>
> > + </refsect1>
>
> I don't think this is safe in any interesting set of cases. Am I
> missing
> something?

No, you are not missing anything. It can be only used to find max LSN in
database which can avoid further corruption

> People falsely thinking that it can be used for this is the primary
> reason for me objecting the patch...

With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 'Andres Freund' 2013-07-08 11:45:56 Re: Review: Patch to compute Max LSN of Data Pages
Previous Message MauMau 2013-07-08 11:34:59 [9.3 bug fix] backends emit hundreds of messages when statistics file is inaccessible