| From: | 'Andres Freund' <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
| Cc: | 'Hari Babu' <haribabu(dot)kommi(at)huawei(dot)com>, 'Robert Haas' <robertmhaas(at)gmail(dot)com>, 'Josh Berkus' <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Review: Patch to compute Max LSN of Data Pages |
| Date: | 2013-07-08 11:45:56 |
| Message-ID: | 20130708114556.GA25171@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-07-08 17:10:43 +0530, Amit Kapila wrote:
> On Monday, July 08, 2013 4:26 PM Andres Freund wrote:
> > On 2013-07-08 16:17:54 +0530, Hari Babu wrote:
> > > + This utility can also be used to decide whether backup is
> > required or not when the data page
> > > + in old-master precedes the last applied LSN in old-standby
> > (i.e., new-master) at the
> > > + moment of the failover.
> > > + </para>
> > > + </refsect1>
> >
> > I don't think this is safe in any interesting set of cases. Am I
> > missing
> > something?
>
> No, you are not missing anything. It can be only used to find max LSN in
> database which can avoid further corruption
Why is the patch submitted documenting it as a use-case then? I find it
rather scary if the *patch authors* document a known unsafe use case as
one of the known use-cases.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hari Babu | 2013-07-08 11:55:21 | Re: Review: Patch to compute Max LSN of Data Pages |
| Previous Message | Amit Kapila | 2013-07-08 11:40:43 | Re: Review: Patch to compute Max LSN of Data Pages |