Re: Review: Patch to compute Max LSN of Data Pages

From: 'Andres Freund' <andres(at)2ndquadrant(dot)com>
To: Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>
Cc: 'Robert Haas' <robertmhaas(at)gmail(dot)com>, 'Josh Berkus' <josh(at)agliodbs(dot)com>, 'Amit kapila' <amit(dot)kapila(at)huawei(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review: Patch to compute Max LSN of Data Pages
Date: 2013-07-08 10:55:51
Message-ID: 20130708105551.GA14555@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2013-07-08 16:17:54 +0530, Hari Babu wrote:
> + This utility can also be used to decide whether backup is required or not when the data page
> + in old-master precedes the last applied LSN in old-standby (i.e., new-master) at the
> + moment of the failover.
> + </para>
> + </refsect1>

I don't think this is safe in any interesting set of cases. Am I missing
something?
People falsely thinking that it can be used for this is the primary
reason for me objecting the patch...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message MauMau 2013-07-08 11:34:59 [9.3 bug fix] backends emit hundreds of messages when statistics file is inaccessible
Previous Message Hari Babu 2013-07-08 10:47:54 Re: Review: Patch to compute Max LSN of Data Pages