Re: ALTER EXTENSION UPGRADE, v3

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ALTER EXTENSION UPGRADE, v3
Date: 2011-02-11 20:55:18
Message-ID: m2d3my47gp.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> I don't see what that does for you. This is still all being examined by
> a particular major release of PG, so what will it do with a require that
> specifies some other major release? Nothing useful. And there's a very
> significant downside, which is that this takes us right back to the
> make-work of having to change all the contrib modules' control files in
> every release cycle.

Mmm, yes we're missing the | operator for dependencies here. I didn't
expect extensions that support more than one major version at a time to
use the feature, but obviously that's not good enough.

> Once again, I see the version numbers as being specifiers for versions
> of the install script files. Not the Postgres version those files are
> being run in. Confusing the two is a bad idea. Confusing the install
> script version numbers with minor release numbers (bugfix level
> identifiers) is even worse. You *don't* want to change these numbers if
> you're just fixing a bug at the C code level.

Agreed on the C side maintenance and releasing. What if your extension
is PL/pgSQL only and you just fixed a bug in one of the functions?

--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2011-02-11 20:57:26 Re: Careful PL/Perl Release Not Required
Previous Message Dimitri Fontaine 2011-02-11 20:52:37 Re: ALTER EXTENSION UPGRADE, v3