Lists: | pgsql-hackers |
---|
From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | coelho(at)cri(dot)ensmp(dot)fr |
Subject: | pgbench patches |
Date: | 2013-07-10 01:19:41 |
Message-ID: | 20130710.101941.1304927178161779021.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Hi Fabien,
I have looked into this:
https://commitfest.postgresql.org/action/patch_view?id=1105
because it's marked as "Ready for committer". However I noticed that
you worried about other pgbench patches such as
https://commitfest.postgresql.org/action/patch_view?id=1103 .
> So I would like to know whether the throttling patch is committed and
> then update the progress patch to take that into account.
Shall I wait for your pgbench --throttle patch becomes ready for committer?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgbench patches |
Date: | 2013-07-10 06:02:29 |
Message-ID: | alpine.DEB.2.02.1307100759380.11644@localhost6.localdomain6 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Hello Tatsuo,
> I have looked into this:
> https://commitfest.postgresql.org/action/patch_view?id=1105
> because it's marked as "Ready for committer". However I noticed that
> you worried about other pgbench patches such as
> https://commitfest.postgresql.org/action/patch_view?id=1103 .
>
>> So I would like to know whether the throttling patch is committed and
>> then update the progress patch to take that into account.
>
> Shall I wait for your pgbench --throttle patch becomes ready for committer?
No. I'll submit another patch to the next commitfest to improve the
progress behavior under throttling, if & when both initial patches are
committed.
--
Fabien.
From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | coelho(at)cri(dot)ensmp(dot)fr |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgbench patches |
Date: | 2013-07-11 00:16:04 |
Message-ID: | 20130711.091604.1302405232495877442.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
> Hello Tatsuo,
>
>> I have looked into this:
>> https://commitfest.postgresql.org/action/patch_view?id=1105
>> because it's marked as "Ready for committer". However I noticed that
>> you worried about other pgbench patches such as
>> https://commitfest.postgresql.org/action/patch_view?id=1103 .
>>
>>> So I would like to know whether the throttling patch is committed and
>>> then update the progress patch to take that into account.
>>
>> Shall I wait for your pgbench --throttle patch becomes ready for
>> committer?
>
> No. I'll submit another patch to the next commitfest to improve the
> progress behavior under throttling, if & when both initial patches are
> committed.
Ok, so I looked into the progress patch. One thing I noticed was:
case 'P':
progress = atoi(optarg);
if (progress <= 0)
{
fprintf(stderr,
"thread progress delay (-P) must not be negative (%s)\n",
optarg);
exit(1);
}
break;
For me, the error message is not quite right, because progress == 0
case is considered error as well in your patch. I sugges you change
the error message something like:
"thread progress delay (-P) must be positive number (%s)\n",
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgbench patches |
Date: | 2013-07-11 06:23:15 |
Message-ID: | alpine.DEB.2.02.1307110818260.11644@localhost6.localdomain6 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Hello Tatsuo,
> For me, the error message is not quite right, because progress == 0
> case is considered error as well in your patch. I sugges you change
> the error message something like:
>
> "thread progress delay (-P) must be positive number (%s)\n",
Please find attached a new version with an updated message.
--
Fabien.
Attachment | Content-Type | Size |
---|---|---|
pgbench-progress-v7.patch | text/x-diff | 5.8 KB |
From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | coelho(at)cri(dot)ensmp(dot)fr |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgbench patches |
Date: | 2013-07-13 02:03:36 |
Message-ID: | 20130713.110336.1071051267574802980.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
> Hello Tatsuo,
>
>> For me, the error message is not quite right, because progress == 0
>> case is considered error as well in your patch. I sugges you change
>> the error message something like:
>>
>> "thread progress delay (-P) must be positive number (%s)\n",
>
> Please find attached a new version with an updated message.
Thanks. I've been testing on Linux now. Starting from coming Tuesday
(Monday is a national holiday in Japan) I will test on Mac OS X and
Windows.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | coelho(at)cri(dot)ensmp(dot)fr |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgbench patches |
Date: | 2013-07-18 01:46:01 |
Message-ID: | 20130718.104601.511712465900892567.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
>> Hello Tatsuo,
>>
>>> For me, the error message is not quite right, because progress == 0
>>> case is considered error as well in your patch. I sugges you change
>>> the error message something like:
>>>
>>> "thread progress delay (-P) must be positive number (%s)\n",
>>
>> Please find attached a new version with an updated message.
>
> Thanks. I've been testing on Linux now. Starting from coming Tuesday
> (Monday is a national holiday in Japan) I will test on Mac OS X and
> Windows.
I have done the test on Mac OS X. Windows testing was done by my
coleague, Yugo Nagata. The results were very positive and I committed
--progress patches.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp