Lists: | pgsql-hackers |
---|
From: | Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | patch for implementing SPI_gettypemod() |
Date: | 2012-02-01 10:23:53 |
Message-ID: | CAPtHcnFQ3z26PEYPn3qx++qhdswaL13R=Jxvz3qn9xMFu=PH7g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Hi All,
This is regarding the TODO item :
"Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
The related message is:
http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php
This basically talks about having an SPI_gettypemod() which returns the
typmod of a field of tupdesc
Please refer the attached patch based on the suggested implementation.
Regards,
Chetan
--
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb
Attachment | Content-Type | Size |
---|---|---|
add_spigettypmod.patch | text/x-diff | 1.4 KB |
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch for implementing SPI_gettypemod() |
Date: | 2012-02-02 14:41:46 |
Message-ID: | CA+TgmobcZbgAiytbqrBhnCtq2beocME5BiB6T2ZwRM-0PvbK9g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Wed, Feb 1, 2012 at 5:23 AM, Chetan Suttraway
<chetan(dot)suttraway(at)enterprisedb(dot)com> wrote:
> Hi All,
>
> This is regarding the TODO item :
> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
>
> The related message is:
> http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php
>
> This basically talks about having an SPI_gettypemod() which returns the
> typmod of a field of tupdesc
>
> Please refer the attached patch based on the suggested implementation.
Please add this to the next CommitFest:
https://commitfest.postgresql.org/action/commitfest_view/open
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From: | Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch for implementing SPI_gettypemod() |
Date: | 2012-02-07 07:02:29 |
Message-ID: | CAPtHcnF0qJokhzWGHh_Z0M+CoWjX=1hv525H0-EKm9dOpu=X3g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Thu, Feb 2, 2012 at 8:11 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Feb 1, 2012 at 5:23 AM, Chetan Suttraway
> <chetan(dot)suttraway(at)enterprisedb(dot)com> wrote:
> > Hi All,
> >
> > This is regarding the TODO item :
> > "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
> >
> > The related message is:
> > http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php
> >
> > This basically talks about having an SPI_gettypemod() which returns the
> > typmod of a field of tupdesc
> >
> > Please refer the attached patch based on the suggested implementation.
>
> Please add this to the next CommitFest:
>
> https://commitfest.postgresql.org/action/commitfest_view/open
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
At the given link, I am able to choose only "System administration" under
commitfest topic.
I think there has to be "server features" or "Miscellaneous".
Regards,
Chetan
--
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb
From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch for implementing SPI_gettypemod() |
Date: | 2012-02-07 21:25:22 |
Message-ID: | 1328649922.24489.15.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
> This is regarding the TODO item :
> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
My first thought was, this should be spelled SPI_gettypmod(). Not sure
what others think.
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch for implementing SPI_gettypemod() |
Date: | 2012-02-08 02:45:26 |
Message-ID: | CA+TgmoYMMJnHXQy2ZEE5002RsOVT3mRthuh1-1qeyNDsimxQ9g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Tue, Feb 7, 2012 at 4:25 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
>> This is regarding the TODO item :
>> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
>
> My first thought was, this should be spelled SPI_gettypmod(). Not sure
> what others think.
+1.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From: | Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch for implementing SPI_gettypemod() |
Date: | 2012-02-08 06:49:56 |
Message-ID: | CAPtHcnG+um+2W_nLroeHD=s8OWRm0tN_+d+nSRov5mEtrOQEXg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Wed, Feb 8, 2012 at 8:15 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Feb 7, 2012 at 4:25 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
> >> This is regarding the TODO item :
> >> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
> >
> > My first thought was, this should be spelled SPI_gettypmod(). Not sure
> > what others think.
>
> +1.
>
>
The reason for using SPI_gettypemod() name was that I did see
SPI_gettypeid().
Anyways, will update patch with recommended name.
Regards,
Chetan
--
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb
From: | Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch for implementing SPI_gettypemod() |
Date: | 2012-02-08 06:58:48 |
Message-ID: | CAPtHcnGHGUA9Uj1=kkCNrP+7HMGsY-s=VJwCbv_e4A+8X1nUPg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Wed, Feb 8, 2012 at 12:19 PM, Chetan Suttraway <
chetan(dot)suttraway(at)enterprisedb(dot)com> wrote:
>
>
> On Wed, Feb 8, 2012 at 8:15 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> On Tue, Feb 7, 2012 at 4:25 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> > On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
>> >> This is regarding the TODO item :
>> >> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
>> >
>> > My first thought was, this should be spelled SPI_gettypmod(). Not sure
>> > what others think.
>>
>> +1.
>>
>>
> The reason for using SPI_gettypemod() name was that I did see
> SPI_gettypeid().
>
> Anyways, will update patch with recommended name.
>
>
> Regards,
> Chetan
>
>
>
Please refer the attached patch which now uses SPI_gettypmod() name.
Regards,
Chetan
--
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb
Attachment | Content-Type | Size |
---|---|---|
add_spigettypmod.1.patch | text/x-diff | 1.3 KB |