Postgres ReviewFest Patch: URI connection string support for libpq

Just reviewed the patch for adding URI connection string support for libpg.

There seem to be many tabs in the patch. Perhaps the indentation is not
correct.

Also, the patch did not run correctly:

patching file src/interfaces/libpq/fe-connect.c
Hunk #1 succeeded at 282 with fuzz 1.
Hunk #2 FAILED at 300.
Hunk #3 FAILED at 583.
Hunk #4 FAILED at 3742.
Hunk #5 FAILED at 4132.
Hunk #6 FAILED at 4279.
Hunk #7 FAILED at 4455.
6 out of 7 hunks FAILED -- saving rejects to file
src/interfaces/libpq/fe-connect.c.rej

Seems like the file has changed since this patch was created. Please
recreate the patch.

Thanks,

Nick Roosevelt

On 01/12/2012 11:07 PM, Nick Roosevelt wrote:
> Just reviewed the patch for adding URI connection string support for
> libpg.
> ...Seems like the file has changed since this patch was created.
> Please recreate the patch.

Thanks for the review. In the CommitFest appliation, it looks like
someone marked this patch "Returned with Feedback" after adding your
review. Whoever did that, it wasn't the right next step for this one.
"Returned with Feedback" suggests a patch has been pushed out of the
CommitFest as not possible to commit yet. It's a final state--normally
a submission going there is finished with, until the next CommitFest
starts. In a case like this one, where a problem is identified but
there's still time to fix it, the right next step is "Waiting on Author".

There's some more details about this at
http://wiki.postgresql.org/wiki/Running_a_CommitFest , which we don't
expect everyone to know because it isn't one of the popular pages to
read. I've sorted out the problem for this one already, just letting
whoever made that change know about the process here.

--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com

> There's some more details about this at
> http://wiki.postgresql.org/wiki/Running_a_CommitFest , which we don't
> expect everyone to know because it isn't one of the popular pages to
> read. I've sorted out the problem for this one already, just letting
> whoever made that change know about the process here.

Yeah, I need to go through the new reviewer's comments. Several of them
got ahead of the group and started marking things up on the CF page;
should be easily cleaned up though.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

Nick Roosevelt <nroose(at)gmail(dot)com> writes:

I am sorry, seems like my new MUA was misconfigured so the two previous
attempts to reply to -hackers@ failed. So here goes again.

> Just reviewed the patch for adding URI connection string support for
> libpg.

Thank you for taking your time on this.

> There seem to be many tabs in the patch. Perhaps the indentation is
> not correct.

I believe tabs for indentation is the project's standard.

> Also, the patch did not run correctly:
> patching file src/interfaces/libpq/fe-connect.c
> Hunk #1 succeeded at 282 with fuzz 1.
> Hunk #2 FAILED at 300.
> Hunk #3 FAILED at 583.
> Hunk #4 FAILED at 3742.
> Hunk #5 FAILED at 4132.
> Hunk #6 FAILED at 4279.
> Hunk #7 FAILED at 4455.
> 6 out of 7 hunks FAILED -- saving rejects to file
> src/interfaces/libpq/fe-connect.c.rej
> Seems like the file has changed since this patch was created. Please
> recreate the patch.

I've just tried to apply the original patch against a clean checkout of
master branch and it applies without a problem (no hunk failed, no
fuzziness.)

Could you please try again on a clean master branch?

--
Regards,
Alex