| Lists: | pgsql-hackers |
|---|
| From: | Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | A few string fixed |
| Date: | 2013-03-20 11:31:12 |
| Message-ID: | CA+mi_8bHc408y9AgfYuv5szUfbWwqkMZUy=oP8wQP0mDE7OY_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hello,
while translating the new PostgreSQL 9.3 strings I've found a couple
questionable. Patches attached.
Cheers,
-- Daniele
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fixed-MultiXactIds-string-warning.patch | application/octet-stream | 1.9 KB |
| 0002-Fixed-pasto-in-hint-string-about-making-views-deleta.patch | application/octet-stream | 1.1 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A few string fixed |
| Date: | 2013-03-20 14:01:56 |
| Message-ID: | 1445.1363788116@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> writes:
> while translating the new PostgreSQL 9.3 strings I've found a couple
> questionable. Patches attached.
Hmm ... I agree with the MultiXactId->MultiXactIds changes, but not with
this one:
> - errhint("To make the view updatable, provide an unconditional ON DELETE DO INSTEAD rule or an INSTEAD OF DELETE trigger.")));
> + errhint("To make the view deletable, provide an unconditional ON DELETE DO INSTEAD rule or an INSTEAD OF DELETE trigger.")));
We use the phrase "updatable view", we don't say "deletable view"
(and this usage is also found in the SQL standard). We could possibly
make the message say "To make the view updatable in this way", or
"... for this purpose", but that seems a bit long-winded to me.
regards, tom lane
| From: | Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A few string fixed |
| Date: | 2013-03-20 16:37:16 |
| Message-ID: | CA+mi_8bu7Ps2XjPYB_BVLzZiQ64HMwatuuX4x79cvLh5L-UFTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Mar 20, 2013 at 2:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> writes:
>> while translating the new PostgreSQL 9.3 strings I've found a couple
>> questionable. Patches attached.
>
> Hmm ... I agree with the MultiXactId->MultiXactIds changes, but not with
> this one:
>
>> - errhint("To make the view updatable, provide an unconditional ON DELETE DO INSTEAD rule or an INSTEAD OF DELETE trigger.")));
>> + errhint("To make the view deletable, provide an unconditional ON DELETE DO INSTEAD rule or an INSTEAD OF DELETE trigger.")));
>
> We use the phrase "updatable view", we don't say "deletable view"
> (and this usage is also found in the SQL standard). We could possibly
> make the message say "To make the view updatable in this way", or
> "... for this purpose", but that seems a bit long-winded to me.
Ok, I'd just thought it was a pasto.
-- Daniele