Lists: | pgsql-hackers |
---|
From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | getting rid of maintainer-check |
Date: | 2013-09-04 02:41:17 |
Message-ID: | 1378262477.28745.5.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
The maintainer-check target never really caught on, I think. Most
people don't run it, and that in turn annoys those who do. Also, it
doesn't provide much functionality.
I propose that we get rid of it and roll the functionality into the
regular build.
Specifically:
- Running duplicate_oids during the regular build was already discussed
elsewhere recently. There are some details to be resolved there, but
it's doable.
- Checking for tabs in SGML files can be run during the regular
documentation build without problems.
- The NLS checks can also be run during the regular NLS-enabled build.
That's it. Any concerns?
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: getting rid of maintainer-check |
Date: | 2013-09-04 15:09:03 |
Message-ID: | CA+Tgmob-K_9BAB9_=n7gYxbpT69hAELWfk27Ych-DfXT5WX-5A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Tue, Sep 3, 2013 at 10:41 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> The maintainer-check target never really caught on, I think. Most
> people don't run it, and that in turn annoys those who do. Also, it
> doesn't provide much functionality.
>
> I propose that we get rid of it and roll the functionality into the
> regular build.
>
> Specifically:
>
> - Running duplicate_oids during the regular build was already discussed
> elsewhere recently. There are some details to be resolved there, but
> it's doable.
>
> - Checking for tabs in SGML files can be run during the regular
> documentation build without problems.
>
> - The NLS checks can also be run during the regular NLS-enabled build.
>
> That's it. Any concerns?
I can't speak for anyone else, but personally I think that sounds like
a significant improvement.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: getting rid of maintainer-check |
Date: | 2013-09-04 15:12:17 |
Message-ID: | 20130904151217.GE11189@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On 2013-09-03 22:41:17 -0400, Peter Eisentraut wrote:
> The maintainer-check target never really caught on, I think. Most
> people don't run it, and that in turn annoys those who do. Also, it
> doesn't provide much functionality.
>
> I propose that we get rid of it and roll the functionality into the
> regular build.
>
> Specifically:
>
> - Running duplicate_oids during the regular build was already discussed
> elsewhere recently. There are some details to be resolved there, but
> it's doable.
Maybe we should also badger cpluspluscheck into a state where it can be
run as part of a normal build if a c++ compiler was detected?
I think it misses vpath support and it might be dependant on some
bashims.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: getting rid of maintainer-check |
Date: | 2013-09-10 20:27:32 |
Message-ID: | 522F80B4.3030803@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On 9/4/13 11:12 AM, Andres Freund wrote:
> Maybe we should also badger cpluspluscheck into a state where it can be
> run as part of a normal build if a c++ compiler was detected?
>
> I think it misses vpath support and it might be dependant on some
> bashims.
That might also be doable. If we could at the same time stick a usable
C++ compiler configuration into PGXS, that would also help the growing
number of extensions that need that and are currently using variously
bad workarounds.
From: | Euler Taveira <euler(at)timbira(dot)com(dot)br> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: getting rid of maintainer-check |
Date: | 2013-09-10 20:51:58 |
Message-ID: | 522F866E.6080309@timbira.com.br |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On 03-09-2013 23:41, Peter Eisentraut wrote:
> The maintainer-check target never really caught on, I think. Most
> people don't run it, and that in turn annoys those who do. Also, it
> doesn't provide much functionality.
>
It has its use (before each release) but I agree that it isn't used
during minor version updates (because you need to update only one or two
po files).
> I propose that we get rid of it and roll the functionality into the
> regular build.
>
By 'regular build' you mean --enable-nls? If so, +1.
> - Running duplicate_oids during the regular build was already discussed
> elsewhere recently. There are some details to be resolved there, but
> it's doable.
>
This has been bashing sufficient developers along the years. +1.
> - Checking for tabs in SGML files can be run during the regular
> documentation build without problems.
>
This one too. +1.
--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: getting rid of maintainer-check |
Date: | 2013-09-13 03:21:10 |
Message-ID: | 1379042470.8575.9.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Tue, 2013-09-03 at 22:41 -0400, Peter Eisentraut wrote:
> The maintainer-check target never really caught on, I think. Most
> people don't run it, and that in turn annoys those who do. Also, it
> doesn't provide much functionality.
>
> I propose that we get rid of it and roll the functionality into the
> regular build.
Here is a patch for that. I also integrated Andrew's Perl version of
duplicate_oids.
The MSVC build needs to be updated separately, if they want to have that
same functionality.
Attachment | Content-Type | Size |
---|---|---|
0001-Replace-duplicate_oids-with-Perl-implementation.patch | text/x-patch | 2.1 KB |
0002-Remove-maintainer-check-target-fold-into-normal-buil.patch | text/x-patch | 7.5 KB |
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: getting rid of maintainer-check |
Date: | 2013-10-09 18:53:51 |
Message-ID: | CA+TgmoZ9Gp+2xFyDGnuosn=9DrMaWsGomL-bBFccei4X2T9gDQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Thu, Sep 12, 2013 at 11:21 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Tue, 2013-09-03 at 22:41 -0400, Peter Eisentraut wrote:
>> The maintainer-check target never really caught on, I think. Most
>> people don't run it, and that in turn annoys those who do. Also, it
>> doesn't provide much functionality.
>>
>> I propose that we get rid of it and roll the functionality into the
>> regular build.
>
> Here is a patch for that. I also integrated Andrew's Perl version of
> duplicate_oids.
>
> The MSVC build needs to be updated separately, if they want to have that
> same functionality.
These patches look OK to me, and everyone who has commented has been
in favor of this proposal. I'll mark this Ready for Committer.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company