| Lists: | pgsql-hackers |
|---|
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | reducing NUMERIC size for 9.1, take two |
| Date: | 2010-07-30 21:58:03 |
| Message-ID: | AANLkTikjvz3R1jn1pSrDD9oHBc_LYMuS1A8u7qrxeckT@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Here's a second version of the main patch, in which I have attempted
to respond to Tom's concerns/suggestions.
(There is still a small, side issue with numeric_maximum_size() which
I plan to fix, but this patch is the good stuff.)
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| numeric_2b-v2.patch | application/octet-stream | 13.6 KB |
| From: | Brendan Jurd <direvus(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: reducing NUMERIC size for 9.1, take two |
| Date: | 2010-08-03 16:58:35 |
| Message-ID: | AANLkTincnsBoQHBP-FyqP2CBXinDZU=YD0o1iHGKQPDz@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 31 July 2010 07:58, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Here's a second version of the main patch, in which I have attempted
> to respond to Tom's concerns/suggestions.
>
> (There is still a small, side issue with numeric_maximum_size() which
> I plan to fix, but this patch is the good stuff.)
>
Applies fine, compiles fine, passes regression tests, and demonstrates
the same space reduction seen with the previous version of the patch.
Marking Ready for Committer.
Cheers,
BJ
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: reducing NUMERIC size for 9.1, take two |
| Date: | 2010-08-03 22:03:55 |
| Message-ID: | 1739.1280873035@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Here's a second version of the main patch, in which I have attempted
> to respond to Tom's concerns/suggestions.
This version looks fine to me.
regards, tom lane
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: reducing NUMERIC size for 9.1, take two |
| Date: | 2010-08-03 23:12:20 |
| Message-ID: | AANLkTikkVAsCgK3Oq5JQtKHm3OhO7BRZQV1b7koLtX+W@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Aug 3, 2010 at 6:03 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Here's a second version of the main patch, in which I have attempted
>> to respond to Tom's concerns/suggestions.
>
> This version looks fine to me.
Excellent. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company