pg_upgrade test picks up unwanted environment values

Lists: pgsql-hackers
From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_upgrade test picks up unwanted environment values
Date: 2012-11-28 14:22:38
Message-ID: 50B61E2E.6010409@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I noticed yesterday while doing some buildfarm tinkering that the test
script for pg_upgrade doesn't unset various important environment values
as pg_regress does. This can cause it to fail e.g. is PGUSER is set, as
it was with my testing.

I propose to add this to the script unless there are objections:

unset PGDATABASE
unset PGUSER
unset PGSERVICE
unset PGSSLMODE
unset PGREQUIRESSL
unset PGCONNECT_TIMEOUT
unset PGHOST
unset PGHOSTADDR

cheers

andrew