I noticed yesterday while doing some buildfarm tinkering that the test
script for pg_upgrade doesn't unset various important environment values
as pg_regress does. This can cause it to fail e.g. is PGUSER is set, as
it was with my testing.
I propose to add this to the script unless there are objections:
unset PGDATABASE
unset PGUSER
unset PGSERVICE
unset PGSSLMODE
unset PGREQUIRESSL
unset PGCONNECT_TIMEOUT
unset PGHOST
unset PGHOSTADDR
cheers
andrew