| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | pg_regress multibyte setting |
| Date: | 2011-01-11 23:06:58 |
| Message-ID: | 1294787218.17361.41.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Is it a good idea that we run make check with MULTIBYTE = SQL_ASCII by
default? We run it with the user's locale by default, so shouldn't we
use the encoding that belongs to the locale by default? Otherwise we
are testing a fairly unrepresentative environment. If you really want
to test SQL_ASCII you could of course choose it explicitly or set the
locale to C.
| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_regress multibyte setting |
| Date: | 2011-01-13 02:52:47 |
| Message-ID: | AANLkTikKDFZzuc2Q0BHeYoZhh7dm_9o-kT+96VN8W8F=@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jan 12, 2011 at 08:06, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Is it a good idea that we run make check with MULTIBYTE = SQL_ASCII by
> default? We run it with the user's locale by default, so shouldn't we
> use the encoding that belongs to the locale by default? Otherwise we
> are testing a fairly unrepresentative environment. If you really want
> to test SQL_ASCII you could of course choose it explicitly or set the
> locale to C.
It seems good to run make check successfully on many platforms,
but we might miss locale-dependent bugs.
Personally speaking, I often recommend to use UTF-8 + C locale combinations
for users, but I'm not sure it's the most common use-cases or not.
--
Itagaki Takahiro
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_regress multibyte setting |
| Date: | 2011-01-13 03:12:48 |
| Message-ID: | 4D2E6DB0.7050101@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 01/12/2011 09:52 PM, Itagaki Takahiro wrote:
> On Wed, Jan 12, 2011 at 08:06, Peter Eisentraut<peter_e(at)gmx(dot)net> wrote:
>> Is it a good idea that we run make check with MULTIBYTE = SQL_ASCII by
>> default? We run it with the user's locale by default, so shouldn't we
>> use the encoding that belongs to the locale by default? Otherwise we
>> are testing a fairly unrepresentative environment. If you really want
>> to test SQL_ASCII you could of course choose it explicitly or set the
>> locale to C.
> It seems good to run make check successfully on many platforms,
> but we might miss locale-dependent bugs.
>
> Personally speaking, I often recommend to use UTF-8 + C locale combinations
> for users, but I'm not sure it's the most common use-cases or not.
>
We have had support for multi-byte testing in the buildfarm for about 2
years. My own Linux buildfarm member is configured to test in both
C/SQL_ASCII and en_US.utf8.
cheers
andrew