Re: pg_regress multibyte setting

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_regress multibyte setting
Date: 2011-01-13 03:12:48
Message-ID: 4D2E6DB0.7050101@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/12/2011 09:52 PM, Itagaki Takahiro wrote:
> On Wed, Jan 12, 2011 at 08:06, Peter Eisentraut<peter_e(at)gmx(dot)net> wrote:
>> Is it a good idea that we run make check with MULTIBYTE = SQL_ASCII by
>> default? We run it with the user's locale by default, so shouldn't we
>> use the encoding that belongs to the locale by default? Otherwise we
>> are testing a fairly unrepresentative environment. If you really want
>> to test SQL_ASCII you could of course choose it explicitly or set the
>> locale to C.
> It seems good to run make check successfully on many platforms,
> but we might miss locale-dependent bugs.
>
> Personally speaking, I often recommend to use UTF-8 + C locale combinations
> for users, but I'm not sure it's the most common use-cases or not.
>

We have had support for multi-byte testing in the buildfarm for about 2
years. My own Linux buildfarm member is configured to test in both
C/SQL_ASCII and en_US.utf8.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2011-01-13 04:52:20 Re: pg_primary_conninfo
Previous Message Bruce Momjian 2011-01-13 03:05:53 Re: Database file copy