| Lists: | pgsql-patches |
|---|
| From: | Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Trivial fix of printing pointer |
| Date: | 2006-05-23 10:28:39 |
| Message-ID: | Pine.LNX.4.58.0605230624370.15900@eon.cs |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
In spirit of incremental improvement, here is a trivial fix to use %p
instead %d to print pointer. -- maybe we should use context name better.
Regards,
Qingqing
| Attachment | Content-Type | Size |
|---|---|---|
| printf_patch.diff | text/plain | 5.0 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Trivial fix of printing pointer |
| Date: | 2006-05-23 14:08:48 |
| Message-ID: | 3361.1148393328@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> In spirit of incremental improvement, here is a trivial fix to use %p
> instead %d to print pointer. -- maybe we should use context name better.
Actually, I wonder whether we shouldn't just get rid of these things
(CTX_printf/CTX1_printf) entirely; they seem fairly useless, especially
since most node types don't have 'em. Certainly if anyone had actually
*used* them in the past several years, there would have been some effort
to convert them to elog's instead of raw printf operations.
regards, tom lane