Re: Trivial fix of printing pointer

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Trivial fix of printing pointer
Date: 2006-05-23 14:08:48
Message-ID: 3361.1148393328@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> In spirit of incremental improvement, here is a trivial fix to use %p
> instead %d to print pointer. -- maybe we should use context name better.

Actually, I wonder whether we shouldn't just get rid of these things
(CTX_printf/CTX1_printf) entirely; they seem fairly useless, especially
since most node types don't have 'em. Certainly if anyone had actually
*used* them in the past several years, there would have been some effort
to convert them to elog's instead of raw printf operations.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2006-05-23 15:23:55 Re: archiver.pid
Previous Message Simon Riggs 2006-05-23 13:14:27 Re: Proposed doc-patch: Identifying the Current WAL file